Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add credentials for telemetry #144

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add credentials for telemetry #144

wants to merge 4 commits into from

Conversation

algochoi
Copy link
Contributor

Summary

Adds telemetry credentials for our Opensearch dev cluster.

Test Plan

Push telemetry events on startup on local conduit instance.

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.82%. Comparing base (442791a) to head (60a010c).
Report is 78 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   67.66%   71.82%   +4.16%     
==========================================
  Files          32       37       +5     
  Lines        1976     2747     +771     
==========================================
+ Hits         1337     1973     +636     
- Misses        570      675     +105     
- Partials       69       99      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@algochoi algochoi marked this pull request as ready for review August 31, 2023 14:13
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move the defaults into the code? That way they can be updated with a software update rather than going stale if we want to change them in the future.

@algochoi
Copy link
Contributor Author

algochoi commented Sep 5, 2023

Could you move the defaults into the code? That way they can be updated with a software update rather than going stale if we want to change them in the future.

@winder
That makes sense since we will likely change the URI some time in the future. But moving the defaults in the code could make it harder for users to set their custom telemetry endpoints (changing source code and recompiling the binary seems a bit more cumbersome). Is this an okay tradeoff here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants