-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add credentials for telemetry #144
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #144 +/- ##
==========================================
+ Coverage 67.66% 71.82% +4.16%
==========================================
Files 32 37 +5
Lines 1976 2747 +771
==========================================
+ Hits 1337 1973 +636
- Misses 570 675 +105
- Partials 69 99 +30 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move the defaults into the code? That way they can be updated with a software update rather than going stale if we want to change them in the future.
@winder |
Summary
Adds telemetry credentials for our Opensearch dev cluster.
Test Plan
Push telemetry events on startup on local conduit instance.